added GBC BIOS palettes + some fixes #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added includes and copyright notice
added more unofficial palettes
fixed rom title reading
| continue; // current line does not contain a palette color definition, so go to next line | ||
| } | ||
|
|
||
| if (startswith(line, "slectedScheme=")) |
There was a problem hiding this comment.
no, it is not:
http://gambatte.svn.sourceforge.net/viewvc/gambatte/gambatte_qt/src/palettedialog.cpp?revision=364&view=markup
(see line 821)
|
I'm not sure if the bitwise operations in "gbcpalettes.h" are portable on other archs (i've run tests only on x86). |
|
The PACK_* macros. They look fine. Shouldn't be any portability issues there. Thanks for implementing this :p |
Themaister
pushed a commit
that referenced
this pull request
Jan 14, 2013
added GBC BIOS palettes + some fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue 1:
#1