Skip to content

librespot panics! when authentication fails  #565

@xou816

Description

@xou816

When authentication fails (bad credentials, non-premium account, etc), librespot panics! instead of returning a proper Result::Err.

I see authenticate and Session::connect both return a io::Error instead of a custom result/error type. Is that intentional? If not, would you be open to a PR introducing a dedicated error type? (I suppose this would require some discussion in terms of implementation and potentially breaking changes).

(by the way, thank you very much for the outstanding work involved in this project!)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions