Skip to content

Misc fixes #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2022
Merged

Misc fixes #551

merged 1 commit into from
Apr 11, 2022

Conversation

mrmonday
Copy link
Contributor

  • Ensure build.sh error on unsupported platforms
  • Replace .unwrap() with .expect() in test suite

@mrmonday
Misc fixes
9651626 
 * Ensure build.sh error on unsupported platforms
 * Replace `.unwrap()` with `.expect()` in test suite
@mrmonday mrmonday merged commit a91a205 into libpnet:master Apr 11, 2022
@mrmonday mrmonday deleted the expect-build branch April 11, 2022 15:39
@teutat3s
Copy link
Contributor 

make test
...
+ echo 'Unsupported testing platform'
Unsupported testing platform

echo $?
0

-> exit 1 missing in run_test()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrmonday @teutat3s