pnet_macros: fix num_bytes calculation #547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: "github" squashes commits by default. I think the two commits in this merge request should go in two separate commits. |
|
@mrmonday can you have a look? |
|
Could you add your sample struct into Sorry for the delay. |
|
In future, the best way to get my attention is to ping me on IRC (#libpnet on irc.libera.chat) - github notifications have a habit of getting buried in my inbox :) |
Done
A few days are not a problem, if it gets into the weeks we should maybe talk about adding some more maintainers ;) |
fcfee53 to
3daa033
Compare
|
I keep adding new maintainers, they always seem to disappear after a while though... |
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following would panic in debug-mode, and produce garbage in release-mode: