Fix #486. #487
Merged
Fix #486. #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when the library is shutting down.
…d to tag leakage and some threads left running. 2) Rewrote plc_tag_set_string. Hopefully it is right this time. It now allocates more tag buffer space when there isn't enough.
kyle-github
added a commit
that referenced
this pull request
Sep 3, 2024
* Make file number optional if input or output file. Fix #481. * Added fix for omitted data file number on I or O files. Added support for a numeric subelement. Fix #479. (#483) * Fix #486. (#487). String size change problem. Fixed with #488. * Added atomic flag and checks to aid in making all sessions terminate when the library is shutting down. Fix #450. * plc_tag_set_string() feature additions (#488). Setting string can change tag data buffer size. And added flag, allow_field_resize, to suppress change. * Added msp response size check before adding new requests to msp with allow_packing=1 and fragmented reads disabled (#489) * Support for Omron to use multi-request packets. --------- Co-authored-by: Phil Smith <105802449+ptsOSL@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #486. Hopefully.
Also fixed some missing rc_dec(tag) lines that were missing. This led to leaked tags and the main session thread not shutting down.
Fixed test_string.c. It certainly was not working before.