Skip to content

Conversation

sukunrt
Copy link
Member

@sukunrt sukunrt commented Jun 12, 2025

This is causing a regression in kubo(ipfs/kubo#10835 (review)) with the new addrs manager which depends on being notified of new listen addresses instead of recomputing all the host's addresses every time on every host.Addrs call.

@sukunrt sukunrt requested a review from p-shahi June 12, 2025 18:44
@p-shahi
Copy link
Member

p-shahi commented Jun 12, 2025

👀 Why is the Tag Push Checker workflow running & failing on this PR @galargh

@galargh
Copy link
Contributor

galargh commented Jun 15, 2025

👀 Why is the Tag Push Checker workflow running & failing on this PR @galargh

Thanks for the ping! I looked into this. The tag push workflow was failing because we were providing wrong arguments to the gh issues create in that workflow. We were providing assignees argument prefixed with @ which is not needed and using a null value for the repo argument. I fixed both of these issues in v1.0.25 release of unified CI and rerun the workflow which now correctly created #3311

The reason why that run showed up in this pull request is because the manually created tag - https://github.com/libp2p/go-libp2p/tree/v0.42.0-alpha-2 - is associated with 0cf29bd, which is currently the HEAD commit of this PR. The workflow itself is triggered on a tag push event, but if that tag happens to be for a commit that is the HEAD of a PR, then the status checks from that workflow will appear in the PR as well.

@sukunrt sukunrt merged commit 90633f6 into master Jun 15, 2025
16 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants