Skip to content

Revert "go-clock migration" #3303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2025
Merged

Revert "go-clock migration" #3303

merged 2 commits into from
May 30, 2025

Conversation

guillaumemichel
Copy link
Contributor

Reverts #3293

See #3293 (comment)

sukunrt
sukunrt previously approved these changes May 30, 2025
View reviewed changes
@sukunrt
Copy link
Member

sukunrt commented May 30, 2025 •
edited
Loading

Can we fork https://github.com/benbjohnson/clock to libp2p/clock and use that?

sukunrt
sukunrt approved these changes May 30, 2025
View reviewed changes
Copy link
Member

@sukunrt sukunrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move it to the libp2p org when we need to make a change to the mock clock.

@sukunrt sukunrt merged commit 31c8c83 into master May 30, 2025
11 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jul 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sukunrt sukunrt sukunrt approved these changes

@MarcoPolo MarcoPolo Awaiting requested review from MarcoPolo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guillaumemichel @sukunrt