Skip to content

eventbus: change slow consumer event from error to warn #3286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

eventbus: change slow consumer event from error to warn #3286

merged 1 commit into from
May 15, 2025

Conversation

guillaumemichel
Copy link
Contributor

Change event bus slow consumer event logging from ERROR to WARN.

WARN seems more appropriate since this isn't an error.

Closes ipfs/kubo#10778

@guillaumemichel guillaumemichel requested a review from sukunrt May 7, 2025 08:02
MarcoPolo
MarcoPolo approved these changes May 7, 2025
View reviewed changes
Copy link
Collaborator

@MarcoPolo MarcoPolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should also increase the slowConsumerWarningTimeout time form 1s to 5s(?)

@gammazero gammazero mentioned this pull request May 13, 2025
Closed
3 tasks
@sukunrt sukunrt merged commit c1c7745 into master May 15, 2025
10 of 11 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jul 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoPolo MarcoPolo MarcoPolo approved these changes

@sukunrt sukunrt Awaiting requested review from sukunrt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

libp2p slow consumer events
3 participants
@guillaumemichel @MarcoPolo @sukunrt