Skip to content

Add missing log for failed GC record unmarshalling in purgeStore() #3273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2025
Merged

Add missing log for failed GC record unmarshalling in purgeStore() #3273

merged 1 commit into from
Apr 21, 2025

Conversation

vipocenka
Copy link
Contributor

This PR replaces a // TODO comment with an actual log statement in the purgeStore() method of the dsAddrBookGc:

Change summary:

  • Added a log.Warnf when proto.Unmarshal fails during garbage collection: 
    log.Warnf("failed to unmarshal record during GC purge: key=%s, err=%v", result.Key, err)

MarcoPolo
MarcoPolo approved these changes Apr 18, 2025
View reviewed changes
Copy link
Collaborator

@MarcoPolo MarcoPolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :) are you using the pstoreds package by any chance?

@vipocenka
Copy link
Contributor Author

@MarcoPolo
I'm not using the pstoreds package myself — I just came across the TODO while reviewing the code and thought it would be helpful to replace it with a proper log statement.

@MarcoPolo MarcoPolo merged commit effdc65 into libp2p:master Apr 21, 2025
11 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jul 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoPolo MarcoPolo MarcoPolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vipocenka @MarcoPolo