identify: rate limit id push protocol #3266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58d3e36 to
beb9ef8
Compare
4069b71 to
7016aa4
Compare
The rate limits id pushes from peers to one every five second with an allowed burst of 10 pushes. This should be enough for all but malfunctioning and malicious peers. We can use the exact same code for autonat, autonatv2, circuit v2, etc. Introducing limits to identify separately to get some feedback for the rate limiting module. For this PR, I'd like to ignore issues regarding where should this piece of code go, and focus on how specifically it should behave. See the long comment in `rateLimiter.allow` for example. We should probably modify `x/time/rate` for our usecase.
89f574d to
a6c9c71
Compare
MarcoPolo
reviewed
Apr 18, 2025
p2p/protocol/identify/ratelimit.go
Outdated
| @@ -0,0 +1,325 @@ | |||
| package identify | |||
There was a problem hiding this comment.
Any reason this is in the identify package?
There was a problem hiding this comment.
I'll move this when introducing it for connections.
There was a problem hiding this comment.
For this PR, I'd like to ignore issues regarding where should this piece of code go, and focus on how specifically it should behave.
There was a problem hiding this comment.
That's fine, but fwiw I would prefer an internal package instead. I know we don't have them very often, but it makes it a little easier to review since the interface is well defined and I can focus on just the one package.
There was a problem hiding this comment.
That's better. Moved to p2p/internal/rate
d4620d8 to
bb1e289
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rate limits id pushes from peers to one every five second with an allowed burst of 10 pushes. This should be enough for all but malfunctioning and malicious peers.
We can use the exact same code for autonat, autonatv2, circuit v2, etc.
Introducing limits to identify separately to get some feedback for #3265. For this PR, I'd like to ignore issues regarding where should this piece of code go, and focus on how specifically it should behave. See the long comment in
rateLimiter.allowfor example. We should probably modifyx/time/ratefor our usecase.Part of: #3265