Skip to content

fix: Add wrapped error type in stream.go #3237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 21, 2025
Merged

fix: Add wrapped error type in stream.go #3237

merged 4 commits into from
Mar 21, 2025

Conversation

Prabhat1308
Copy link
Contributor

fixes #3156

sukunrt
sukunrt requested changes Mar 17, 2025
View reviewed changes
Copy link
Member

@sukunrt sukunrt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just use:
StreamError from:

https://github.com/libp2p/go-libp2p/blob/master/core/network/mux.go#L17

You can set the ErrorCode to 0 and use the appropriate Remote flag.

@Prabhat1308
Copy link
Contributor Author

Prabhat1308 commented Mar 17, 2025 •
edited
Loading

Removed the custom defined StreamError and using the already defined one from mux.go. We do get the Network.ErrReset from here now

go-libp2p/core/network/mux.go

Line 42 in b663d7b

return []error{ErrReset, s.TransportError}

Also on the remote flags I have assumed the read errors are initiated by the remote peer while write ones are initiated by the local peer. Let me know if this assumption is wrong .

@sukunrt
Copy link
Member

sukunrt commented Mar 17, 2025

You can just use the remote field on webtransport.StreamError

@Prabhat1308 Prabhat1308 requested a review from sukunrt March 17, 2025 14:02
sukunrt
sukunrt reviewed Mar 18, 2025
View reviewed changes
@sukunrt
Copy link
Member

sukunrt commented Mar 18, 2025

Thanks @Prabhat1308

@sukunrt sukunrt merged commit 1f6232d into libp2p:master Mar 21, 2025
9 of 10 checks passed
@sukunrt sukunrt mentioned this pull request Mar 21, 2025
Closed
@Prabhat1308 Prabhat1308 deleted the pv/informative_error branch March 21, 2025 15:47
@BrewTestBot BrewTestBot mentioned this pull request Jul 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoPolo MarcoPolo MarcoPolo approved these changes

@sukunrt sukunrt sukunrt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return wrapped network.ErrReset error type with more info
3 participants
@Prabhat1308 @sukunrt @MarcoPolo