feat(swarm): logging waitForDirectConn return error #3183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
04c7284 to
cb1ebb4
Compare
sukunrt
reviewed
Feb 12, 2025
p2p/net/swarm/swarm.go
Outdated
| @@ -510,6 +510,7 @@ func (s *Swarm) NewStream(ctx context.Context, p peer.ID) (network.Stream, error | |||
| var err error | |||
| c, err = s.waitForDirectConn(ctx, p) | |||
| if err != nil { | |||
| log.Debugf("[%s] waitForDirectConn error: %s", p, err) | |||
There was a problem hiding this comment.
Suggested change
| log.Debugf("[%s] waitForDirectConn error: %s", p, err) | |
| log.Debugf("failed to upgrade limited conn to direct conn for peer %s: %s", p, err) |
sukunrt
reviewed
Feb 12, 2025
sukunrt
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I tested the relay connection with the new version, I was able to successfully connect to the server peer, but a
context deadline exceedederror occurred when callingNewStreambecauseWithAllowLimitedConnwas not used.This error caused me trouble, and I finally found that it was a timeout in
waitForDirectConn(because my environment could not successfully holepunch).Logging the errors returned by waitForDirectConn can help more developers locate errors and know through code logic that WithAllowLimitedConn is needed.