autonatv2: allow multiple concurrent requests per peer #3187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoPolo
reviewed
Feb 13, 2025
|
No science to this. I guess 2 is okay too. |
This fixes the flaky test: TestServerDialData(#3179) The exact sequence of events that flakiness is: The client rejects the dial data request by resetting the stream. The client makes a new request to the server. The server rejects this request as it hasn't read the previous stream's reset yet. It is better to allow multiple concurrent requests per peer. 5 concurrent requests per peer is okay.
b769f59 to
d55e2c9
Compare
|
changed this to 2. |
MarcoPolo
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the flaky test:
TestServerDialData(#3179) The exact sequence of events that flakiness is:
The client rejects the dial data request by resetting the stream. The client makes a new request to the server. The server rejects this request as it hasn't read the previous stream's reset yet.
It is better to allow multiple concurrent requests per peer. 5 concurrent requests per peer is okay.