ios13 debug server fix (#793) #860
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to send SSL shutdown message. As in debugserver this message will be considered as GDB server communication and break things
This was referenced Oct 10, 2019
pachoo
added a commit
to fortify/libimobiledevice
that referenced
this pull request
Nov 7, 2019
…mobiledevice Pulling in libimobiledevice PR to get idevicedebug working on iOS 13: libimobiledevice#860
|
What is the status of this fix? |
|
From my perspective this fix does what it is supposed to to and I did not recognize any negative effects. @nikias: Is there something that contradicts applying this patch? |
|
Hi, Are there any chances to get this fix merged soon? Thanks. |
|
Some days ago I had a conversation with @FunkyM and he promised to process some of the PRs including this in March. |
|
Merged after rebase. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR extends
idevice_connection_disable_sslwith option to not send SSL shutdown but only free SSL related objects.it is required in case when SSL handshake is required by service but plain text communication is expected after it. it is wrong to use
idevice_connection_disable_sslin this case as it will send SSL traffic over underlying socket and plain text service will receive SSL data and consider it as protocol data. E.g. as GDB one.