Skip to content

Fix circular includes between types.h and oid.h #7059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2025
Merged

Fix circular includes between types.h and oid.h #7059

merged 1 commit into from
Jun 5, 2025

Conversation

georgthegreat
Copy link
Contributor

Fix the following warning reported by clang-tidy:

contrib/libs/libgit2/include/git2/oid.h:11:10: error: circular header file dependency detected while including 'types.h', please check the include path [misc-header-include-cycle,-warnings-as-errors]
   11 | #include "types.h"
      |          ^
contrib/libs/libgit2/include/git2/types.h:70:10: note: 'oid.h' included from here
   70 | #include "oid.h"

@ethomson ethomson merged commit 3082736 into libgit2:main Jun 5, 2025
19 checks passed
@ethomson
Copy link
Member

ethomson commented Jun 5, 2025

Thanks!

@BrewTestBot BrewTestBot mentioned this pull request Jun 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethomson ethomson ethomson approved these changes

Assignees
No one assigned
Labels
build compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgthegreat @ethomson