alternates: allow relative paths in all repositories #7019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git does not limit relative paths in alternates to the first repository, so libgit2 shouldn't either.
|
The code has behaved this way since it was originally merged in 85e7efa1630855c5c8bd9893f732494bda51b591 in PR #719. I can't see an explanation as to why the code decided to only load relative links for the current repo in either place. Maybe git itself used to behave this way, but current versions definitely do not. FWIW we hit this in CrOS with details in https://issuetracker.google.com/214563046, although it's not terribly interesting tbh. |
|
Indeed; I'm not sure either, but it looks like your analysis is correct. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git does not limit relative paths in alternates to the first repository, so libgit2 shouldn't either.