Minor bug fixes #6695
Merged
Minor bug fixes #6695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethomson
commented
Dec 18, 2023
src/cli/cmd_index_pack.c
Outdated
| @@ -108,6 +105,9 @@ int cmd_index_pack(int argc, char **argv) | |||
| cli_progress_finish(&progress); | |||
|
|
|||
| done: | |||
| if (!read_stdin && fd > 0) | |||
There was a problem hiding this comment.
Suggested change
| if (!read_stdin && fd > 0) | |
| if (!read_stdin && fd >= 0) |
If we're reading an on-disk packfile, ensure that we close the file descriptor on error.
`GIT_ASSERT` may be a macro for `assert` (when `GIT_ASSERT_HARD` is defined), which may differ in debug builds. Pull the assignment out of the assertion.
`opts` may be null; check before dereferencing.
f7d1319 to
113b995
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.