Thanks!

This has created the converse problem for me on msys2:

-- Performing Test IS_WNO_UNUSED_FUNCTION_SUPPORTED
-- Performing Test IS_WNO_UNUSED_FUNCTION_SUPPORTED - Success
-- Performing Test IS_WNO_IMPLICIT_FALLTHROUGH_SUPPORTED
-- Performing Test IS_WNO_IMPLICIT_FALLTHROUGH_SUPPORTED - Success
-- Checking for module 'ssh2'
--   No package 'ssh2' found

@jeroen which OS are you on? Which cmake version?

I had tested this on Windows/Linux/macOS and it was working :( . Though it was using the static library on Linux (not the system shared one).

Did reverting the change fix the problem for you?

This is an msys2 based build on Windows, but as far as I can tell, the pkg-config file is called libssh2 on all platforms?

For example on mac:

pkg-config --libs ssh2
# Package ssh2 was not found in the pkg-config search path.
# Perhaps you should add the directory containing `ssh2.pc'
# to the PKG_CONFIG_PATH environment variable
# No package 'ssh2' found

pkg-config --libs libssh2
# -L/usr/local/Cellar/libssh2/1.11.0_1/lib -L/usr/local/opt/openssl@3/lib -lssh2 -lssl -lcrypto -R/usr/local/opt/openssl@3/lib

The problem will go unnoticed on most platforms because cmake can guess libssh2.so but in my platform this does not work because the static libssh2.a needs additional linker flags.

Reverting this PR indeed fixes my issue.

Well, it didn't work on Windows+MSVC (see the linked issue above).

But I guess this should be reverted then, and the issue re-opened?

Will need someone with better CMake knowledge then me to fix :( .

Dit it actually solve anything for you? In that case maybe you should special case on MSVC. I have never used MSVC so I don't know if it is different from other platforms.

OK I think I see the problem. I'll send a PR.

Dit it actually solve anything for you?

Yes it did solve my issue (which is how I found #5981 and proposed this solution)

OK I think I see the problem. I'll send a PR.

Thanks 🏅

OK I have sent the PR ==> #6602

I'm going to temporarily revert this one so that we can get v1.7.1 out the door while #6602 is being reviewed.