Log the exception inside flush and fix NullPointerException if LocalStorage is not supported #5838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s from the same type in toObject (the constructors are also deprecated since java 9)
MrStahlfelge
approved these changes
Nov 10, 2019
|
Why should |
|
It makes the whole game unplayable if the exception occurs. Maybe an IOException would be better? So the developer know and can handle the case of not saveable? |
|
Because of backwards compatibility (in the past, possibility to save was granted) and to keep it conform with the other platforms. There's also nothing to gain here. Handling the exception yourself has no value. Additionally, it is completely unexpected that the execption is thrown on flush. The moment I would expect it is when the object is loaded with Gdx.app.getPreferences. |
MrStahlfelge
approved these changes
Nov 18, 2019
|
Thanks for testing and approving |
|
Looks okay to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We experienced some "Couldn't flush preferences" erros. The cause seem to be that
getLocalStorageIfSupportedcan return null if the browser doesn't support it or "block third-party cookies" is enabled. Then inflush, GwtPreferences tries to access to LocalStorage but it's null.Logging the original exception is helpful to get causes of problems.
Also removed the unnecessary creation of objects from the same type in toObject (the constructors are deprecated since java 9)