Feature policy implementation for gwt #5784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, can you put the html container site you tested with here? Makes it easier for me and others to test. Thanks. :) |
|
Here's a live version https://libgdx2.v22018086706171227.nicesrv.de/ |
# Conflicts: # backends/gdx-backends-gwt/src/com/badlogic/gdx/backends/gwt/GwtInput.java
|
Is there a specific reason why this doesn't get merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the feature policy, developers can allow and disallow some web browser features in iframes. If the game wants to access a disallowed feature, an error is thrown. This happens for example on itch.io. See for example the game of @MrStahlfelge for the game jam https://mrstahlfelge.itch.io/gdxjam1908. Make sure to use chrome. There will be an error in the console
Uncaught (in promise) DOMException: Failed to construct 'Accelerometer': Access to sensor features is disallowed by feature policyThis PR adds a check whether the feature, in this case accelerometer, is allowed. If not isPeripheralAvailable returns false and the setupAccelerometer method wont get called.
https://developers.google.com/web/updates/2018/06/feature-policy
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Feature-Policy