improve gitignore template fix libgdx/libgdx#4560 #4580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mostly for the benefit of people new to git. Just like with gradle we have all the dependencies declared in the root build.gradle file as that makes it easier for people new to gradle to see project definitions, compare them and add/remove what they need without having to forage around in an environment they aren't used to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed in #4560, here is the fix (maybe not the final fix).
I'm not really confident with these modifications because I'm not using all OS/IDE/Targets. I'm using eclipse on linux and mostly target desktop and android so I think this fix should be validated by more contributors.
Has you can see, what I've done so far is :
Note that I could use single wildcard instead of path for every sub project (for instance /*/dist/) but it could conflicts with some project specific folder structure.
@Tom-Ski : I don't really understand why you want to keep just one big file instead of dispatching some parts in related sub projects. It would be cleaner way for many reasons :
Thanks to point me in the right direction in order to improve these changes.