PolygonSprite minor improvements #4555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypherdare
commented
Jan 21, 2017
| @@ -37,7 +37,6 @@ | |||
|
|
|||
| public PolygonSprite (PolygonRegion region) { | |||
| setRegion(region); | |||
| setColor(1, 1, 1, 1); | |||
There was a problem hiding this comment.
Removed for being redundant. setRegion() always applies the color.
cypherdare
commented
Jan 21, 2017
| @@ -62,7 +61,6 @@ public void set (PolygonSprite sprite) { | |||
| scaleX = sprite.scaleX; | |||
| scaleY = sprite.scaleY; | |||
| color.set(sprite.color); | |||
| dirty = sprite.dirty; | |||
There was a problem hiding this comment.
This line was a bug. The complete vertex data array is not copied from the other sprite, so this sprite is always dirty at this point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed a couple of redundant lines (I'll explain below) and added an optimization when setting a new region.
Resolves #3722 by correcting the docs for the
getColormethods. I didn't simply say "don't modify the returned color" because it would be valid to pass the color back intosetColor, which might be convenient if doing some sort of transformation on the existing color.