Skip to content

Conversation

rolandvigh
Copy link
Contributor

No description provided.

@intrigus
Copy link
Contributor

intrigus commented Jan 5, 2017

This should not be necessary, because the isIos variable should be true for robovm-ios and moe-ios.
Maybe moe-ios is detected as android, since it's based on Android ART.

@liliomk
Copy link
Contributor

liliomk commented Jan 5, 2017

Yes, it is recognized as Android. In MOE 1.3.0-beta-1, we changed the behavior of System.loadLibrary to be compliant with VM specs, which introduced this issue. Would you like us to change the isIos variable instead of creating an isMoe?

@intrigus
Copy link
Contributor

intrigus commented Jan 5, 2017

Would be better to fix that moe is recognized as Android, so changing https://github.com/libgdx/libgdx/pull/4519/files#diff-02298d26f3a99802c7af1ef20425088fL51 to

// MOE is recognized as Android, since it's based on ART, so check that it's really Android
if (vm != null && vm.contains("Android Runtime") && !isMOE) {

and changing the check isIos || isMOE back to isIos should work, but ultimately @badlogic has to decide.
Just my 2 cent :)

@liliomk
Copy link
Contributor

liliomk commented Jan 24, 2017

Please ignore this pull request, we are working on a new one with proper Multi-OS Engine 1.3.0 (currently beta) support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants