Enable parallel direct writes on the same file #659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Could you please ping this request once the necessary patches have been merged into the kernel? |
bsbernd
approved these changes
Mar 2, 2023
bsbernd
reviewed
Mar 2, 2023
lib/fuse.c
Outdated
| @@ -4669,6 +4675,7 @@ static const struct fuse_opt fuse_lib_opts[] = { | |||
| FUSE_LIB_OPT("noforget", remember, -1), | |||
| FUSE_LIB_OPT("remember=%u", remember, 0), | |||
| FUSE_LIB_OPT("modules=%s", modules, 0), | |||
| FUSE_LIB_OPT("parallel_direct_write=%d",parallel_direct_writes, 0), | |||
There was a problem hiding this comment.
Nit: There should be a space after the comma.
bsbernd
approved these changes
Mar 2, 2023
|
@d-hans there is a merge conflict, can you please rebase? |
bsbernd
requested changes
Mar 3, 2023
include/fuse_common.h
Outdated
| @@ -68,6 +68,10 @@ struct fuse_file_info { | |||
| the file/directory is closed. */ | |||
| unsigned int keep_cache : 1; | |||
|
|
|||
| /** Can be filled by open/create, to allow parallel direct writes on this | |||
| * file */ | |||
| unsigned int parallel_direct_writes; | |||
Right now fuse kernel serializes direct writes on the same file. This serialization is good for such FUSE implementations which rely on the inode lock to avoid any data inconsistency issues but it hurts badly such FUSE implementations which have their own mechanism of dealing with cache/data integrity and can handle parallel direct writes on the same file. This patch allows parallel direct writes on the same file to be enabled with the help of a flag FOPEN_PARALLEL_DIRECT_WRITES. FUSE implementations which want to use this feature can set this flag during fuse init. Default behaviour remains same i.e no parallel direct writes on the same file. Corresponding fuse kernel patch(Merged). https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v6.2&id=153524053bbb0d27bb2e0be36d1b46862e9ce74c
bsbernd
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows parallel direct writes on the same file to be enabled with the help of a flag FOPEN_PARALLEL_DIRECT_WRITES. FUSE implementations which want to use this feature
can set this flag during fuse init. Default behavior remains same i.e no parallel direct writes on
the same file.
Corresponding fuse kernel patch(Merged).
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v6.2&id=153524053bbb0d27bb2e0be36d1b46862e9ce74c