Added evhttp request on free callback #591
Conversation
e9f13c6 to
63a6193
Compare
|
This patch is what I want |
I meant that we need to document order/cases in which callbacks will be called, so that it will be possible to figure this out without looking into sources, and since you adding yet another callback (and I assume that already look into all available callbacks in http and your knowledge was fresh, egh was cause it passed almost year since this pull request had been submitted) I would love to see separate patch that documents this. |
| /* | ||
| * Free callback - called just before the request is freed. | ||
| */ | ||
| void (*on_free_cb)(struct evhttp_request *, void *); |
There was a problem hiding this comment.
This is an ABI break. The soname needs to be bumped.
There was a problem hiding this comment.
Actually using evhttp_request directly is not recommended, but yes it is.
And there is a comment in this file:
Data structures for http. Using these structures may hurt forward
compatibility with later versions of Libevent: be careful!
But nobody reads headers
|
@pprindeville I'm really sorry for abandoning this, sadly, but I haven't have enough time for libevent for a long time already. |
This adds a callback from
evhttp_request_free()that guarantees resources associated with anevhttp_requestcan be deallocated. I found this necessary because the on complete and on error callbacks are not always called which can lead to memory leaks. This callback makes the resource deallocation explicit.