build: Add Iphlpapi to Libs.private in *.pc files on Windows
#1622
Conversation
It has been required since libevent#923 at least for the `if_nametoindex` call.
|
Thanks! So it fixes #1110 right? |
I don't think so. From #1110 (comment):
And this PR does not make the code work on Windows XP. It basically resolves issues for downstream projects, which rely on |
|
Make sense, thanks. Maybe you can add auto-detection? Though I guess it should be done at runtime and during configuring libevent's build? |
Would you mind clarifying your point, please? Can libevent's build be configured in way that eliminates the need to link to the Iphlpapi library? |
I mean do what had been described in #1110 |
I see.
Yes. It seems reasonable to do not mix in a single PR the library code change with changes in the build artifacts dedicated for downstream projects. |
|
The CI issue should be resolved now -- microsoft/linux-package-repositories#130. Mind re-running jobs? |
8c935e6 depends: Fix CMake-generated `libevent*.pc` files (Hennadii Stepanov) Pull request description: Broken out of #30454. This is a backport of the merged upstream PR: libevent/libevent#1622. Note that after #29835 we might end up dropping pkg-config and using the installed CMake files directly, but that depends on whether or not enough distros actually ship those files. Either way, having fixed up .pc files won't hurt. ACKs for top commit: hebasto: ACK 8c935e6. fanquake: ACK 8c935e6 Tree-SHA512: 259c2ad78fb9e90370a7205dc71c40acda1a872f6509435133bc1c4c2c3de57366e80679aa083e13ed85e7966883dc470c0147ee171a2ed0171a18cd5ffc99b3
8c935e6 depends: Fix CMake-generated `libevent*.pc` files (Hennadii Stepanov) Pull request description: Broken out of bitcoin#30454. This is a backport of the merged upstream PR: libevent/libevent#1622. Note that after bitcoin#29835 we might end up dropping pkg-config and using the installed CMake files directly, but that depends on whether or not enough distros actually ship those files. Either way, having fixed up .pc files won't hurt. ACKs for top commit: hebasto: ACK 8c935e6. fanquake: ACK 8c935e6 Tree-SHA512: 259c2ad78fb9e90370a7205dc71c40acda1a872f6509435133bc1c4c2c3de57366e80679aa083e13ed85e7966883dc470c0147ee171a2ed0171a18cd5ffc99b3
8c935e6 depends: Fix CMake-generated `libevent*.pc` files (Hennadii Stepanov) Pull request description: Broken out of bitcoin#30454. This is a backport of the merged upstream PR: libevent/libevent#1622. Note that after bitcoin#29835 we might end up dropping pkg-config and using the installed CMake files directly, but that depends on whether or not enough distros actually ship those files. Either way, having fixed up .pc files won't hurt. ACKs for top commit: hebasto: ACK 8c935e6. fanquake: ACK 8c935e6 Tree-SHA512: 259c2ad78fb9e90370a7205dc71c40acda1a872f6509435133bc1c4c2c3de57366e80679aa083e13ed85e7966883dc470c0147ee171a2ed0171a18cd5ffc99b3
8c935e6 depends: Fix CMake-generated `libevent*.pc` files (Hennadii Stepanov) Pull request description: Broken out of bitcoin#30454. This is a backport of the merged upstream PR: libevent/libevent#1622. Note that after bitcoin#29835 we might end up dropping pkg-config and using the installed CMake files directly, but that depends on whether or not enough distros actually ship those files. Either way, having fixed up .pc files won't hurt. ACKs for top commit: hebasto: ACK 8c935e6. fanquake: ACK 8c935e6 Tree-SHA512: 259c2ad78fb9e90370a7205dc71c40acda1a872f6509435133bc1c4c2c3de57366e80679aa083e13ed85e7966883dc470c0147ee171a2ed0171a18cd5ffc99b3
The Iphlpapi library has been required since #923 at least for the
if_nametoindexcall when cross-compiling for Windows with static linking.Refs: #1110.