Skip to content

disallow empty header names #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 26, 2024
Merged

disallow empty header names #1690

merged 2 commits into from
Jul 26, 2024

Conversation

Coeur
Copy link
Contributor

@Coeur Coeur commented Jul 9, 2024 •
edited
Loading

Fix #1686

In theory, we could be more strict, since there is only a subset of allowed characters:

tchar          = "!" / "#" / "$" / "%" / "&" / "'" / "*"
                / "+" / "-" / "." / "^" / "_" / "`" / "|" / "~"
                / DIGIT / ALPHA
                ; any VCHAR, except delimiters

But I'd skip such verification, unless there is a legitimate interest (versus performances).

azat
azat reviewed Jul 9, 2024
View reviewed changes
Copy link
Member

@azat azat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but can you please also add a test

@azat azat self-assigned this Jul 9, 2024
@Coeur
Copy link
Contributor Author

Coeur commented Jul 9, 2024 •
edited
Loading

Slightly busy nowadays, so I may postpone adding a test for a certain number of days. But yes, once I got the opportunity, I'll try.

Suggestion: add a label "needs a test" to pull requests missing a test.

@Coeur Coeur mentioned this pull request Jul 23, 2024
Closed
@Coeur
Copy link
Contributor Author

Coeur commented Jul 23, 2024

Test added in 270fb06.

@azat azat merged commit 9848df5 into libevent:master Jul 26, 2024
60 of 70 checks passed
@Coeur Coeur deleted the coeur/RFC-9110 branch July 27, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azat azat azat approved these changes

Assignees

@azat azat

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTTP parser allows empty header names
2 participants
@Coeur @azat