Skip to content

Conversation

Coeur
Copy link
Contributor

@Coeur Coeur commented Jun 24, 2024

Fixes #1574.
Supersedes #1575.
The solution used is identical to the one in becat.c.

Copy link
Member

@azat azat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. BTW signals are not supported on windows, so let's just hide this code under #ifndef _WIN32?

@Coeur
Copy link
Contributor Author

Coeur commented Jun 24, 2024

But which part of the code (which line numbers) ?
And if the file is currently compiling fine, why adding macros that would complexify the file?

@azat
Copy link
Member

azat commented Jun 26, 2024

And if the file is currently compiling fine, why adding macros that would complexify the file?

To avoid readers of this file think that signals is supported on windows

@azat
Copy link
Member

azat commented Jun 26, 2024

Hm, actually, windows does support signals, but they are not asynchronous, plus SIGINT creates a thread - very odd

@azat
Copy link
Member

azat commented Jun 26, 2024

It is ok to leave as-is, but the codes does not compile. Please fix

http-server.obj : error LNK2019: unresolved external symbol strsignal referenced in function do_term [D:\a\libevent\libevent\build\http-server.vcxproj]
D:\a\libevent\libevent\build\bin\Debug\http-server.exe : fatal error LNK1120: 1 unresolved externals [D:\a\libevent\libevent\build\http-server.vcxproj]

Copy link
Member

@azat azat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@Coeur Coeur force-pushed the hmartinez82/http_server_win32 branch from 2f45f71 to 0416d17 Compare June 26, 2024 16:10
@Coeur Coeur requested a review from azat June 26, 2024 16:11
@Coeur Coeur mentioned this pull request Jun 26, 2024
@azat azat changed the title Use evutil_socket_t instead in http server sample and handle 64 bit Windows samples: use evutil_socket_t instead and handle 64 bit Windows Jul 8, 2024
@azat azat merged commit 49d6b4b into libevent:master Jul 8, 2024
@Coeur Coeur deleted the hmartinez82/http_server_win32 branch July 8, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

HTTP Server sample fails to compile for Windows x64
3 participants