-
Notifications
You must be signed in to change notification settings - Fork 3.5k
samples: use evutil_socket_t instead and handle 64 bit Windows #1682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. BTW signals are not supported on windows, so let's just hide this code under #ifndef _WIN32
?
But which part of the code (which line numbers) ? |
To avoid readers of this file think that signals is supported on windows |
Hm, actually, windows does support signals, but they are not asynchronous, plus SIGINT creates a thread - very odd |
It is ok to leave as-is, but the codes does not compile. Please fix
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
2f45f71
to
0416d17
Compare
Fixes #1574.
Supersedes #1575.
The solution used is identical to the one in becat.c.