Skip to content

Only use relative paths for install DESTINATION option #1405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2023
Merged

Only use relative paths for install DESTINATION option #1405

merged 1 commit into from
May 15, 2023

Conversation

jeremy-murphy
Copy link
Contributor

@jeremy-murphy jeremy-murphy commented Jan 27, 2023 •
edited by azat
Loading

As described in #1404, the explicit use of CMAKE_INSTALL_PREFIX conflicts with using command-line --prefix.

This simply removes all explicit use of CMAKE_INSTALL_PREFIX.

Fixes: #1404

@jeremy-murphy
Copy link
Contributor Author

I had a look through some of the failed builds, and they seem unrelated to these changes, but I'm not an expert on libevent.

@azat
Copy link
Member

azat commented Jan 28, 2023

macos failure looks related:

[test-export] test for install tree(in non-system-wide path)
[test-export] fail: link core and run core expects success but gets failure.

@jeremy-murphy
Copy link
Contributor Author

macos failure looks related:

[test-export] test for install tree(in non-system-wide path)
[test-export] fail: link core and run core expects success but gets failure.

That's down on line 2,039, but there are dozens of errors unrelated to how files are installed before it, such as this starting on line 267.

/Applications/Xcode_14.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc -isysroot /Applications/Xcode_14.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk -mmacosx-version-min=12.6 -Wl,-search_paths_first -Wl,-headerpad_max_install_names "CMakeFiles/test-export.dir/test-export.c.o" -o test-export -Wl,-rpath,/Users/runner/work/libevent/libevent/build/lib /Users/runner/work/libevent/libevent/build/lib/libevent_core-2.2.1.dylib
Undefined symbols for architecture x86_64:
"_evdns_base_free", referenced from:
_test in test-export.c.o
"_evdns_base_new", referenced from:
_test in test-export.c.o
"_evhttp_free", referenced from:
_test in test-export.c.o
"_evhttp_new", referenced from:
_test in test-export.c.o
"_evrpc_free", referenced from:
_test in test-export.c.o
"_evrpc_init", referenced from:
_test in test-export.c.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

But the first error, which I'm not sure if it's truly an error or just a warning is on line 24.

could not load cache

Can we selectively re-run only the builds that failed?

@azat
Copy link
Member

azat commented Feb 4, 2023

Can we selectively re-run only the builds that failed?

GitHub does not allow this without write access to the repo

That's down on line 2,039, but there are dozens of errors unrelated to how files are installed before it, such as this starting on line 267

Yes, it is hard to debug this test.
But the failure is indeed related, can you please take a look?
You can adjust the test logs.
Also it seems that it first print stderr and only after stdout.

But the first error, which I'm not sure if it's truly an error or just a warning is on line 24.

Likely this does not leads to the test failures, since this test has some negative cases, which I believe can have such logs.

@jeremy-murphy
Copy link
Contributor Author

OK, thanks @azat, I'll investigate.

@azat azat force-pushed the install_prefix branch from 641758c to 42d8251 Compare May 14, 2023 20:40
@azat
Copy link
Member

azat commented May 14, 2023

I've recently merged #1397, but there is still a problem, can you please continue on this one?

@azat
Copy link
Member

azat commented May 14, 2023

But it removes some oddity from the test, maybe the test will be fixed by itself, let's check.

@azat azat force-pushed the install_prefix branch from 42d8251 to c3ba9f6 Compare May 14, 2023 21:04
azat
azat approved these changes May 14, 2023
View reviewed changes
Copy link
Member

@azat azat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, hope that the export test will pass.

@azat azat self-assigned this May 14, 2023
@azat azat mentioned this pull request May 14, 2023
Closed
21 tasks
@jeremy-murphy
Copy link
Contributor Author

Hi @azat , thanks for checking back in! Sorry, I did forget about this one, and I honestly wasn't sure how to test it either.
Fingers crossed that #1397 resolved the unexpected failure.

@azat azat merged commit 81c6b88 into libevent:master May 15, 2023
@jeremy-murphy jeremy-murphy deleted the install_prefix branch May 16, 2023 00:11
@azat azat mentioned this pull request May 20, 2023
Merged
azat added a commit that referenced this pull request May 20, 2023
@azat
Revert "cmake: Only use relative paths for install DESTINATION option (…
2c2ffb8 
…#1405)"

After rebasing I broke the initial intention of this patch, so it simply
should be reverted.

This reverts commit 81c6b88.
@kurtlau kurtlau mentioned this pull request Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azat azat azat approved these changes

Assignees

@azat azat

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

install DESTINATION uses CMAKE_INSTALL_PREFIX inconsistently, which conflicts with --prefix
2 participants
@jeremy-murphy @azat