Clarify SetRecords example/doc
#174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gucci-on-fleek
requested changes
May 5, 2025
There was a problem hiding this comment.
No, this is correct as-is; calling SetRecords only on records with names a.example.com. should not affect records with names b.example.com.. But I do see how you could easily miss that the first three lines are for a different domain than the last two lines since there's only a single-character difference between them.
Could you please replace the names a.example.com. and b.example.com. with either one.example.com. and two.example.com. or alpha.example.com. and beta.example.com. (your choice). That should hopefully make this clearer for future users. Thanks!
SetRecords example/docSetRecords example/doc
|
Ahh yep completely missed the a/b part! Thanks for pointing that out. |
mholt
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my understanding the example is wrong, SetRecords should "overwrite" ::3 and ::4 (like it does for the A record above)