ICMP packets generate invalid IP header length #4
Description
If generating ICMP packets, IP header's length field doesn't include the length of the IP header itself, producing invalid IP packets. Other protocols are correct.
Tested on latest master 0123747 on macOS 10.13.6.
Example:
nemesis icmp -d en0
# generates invalid ip len of 8
18:54:16.086289 IP bad-len 8
0x0000: 4500 0008 7395 0000 ff01 cae4 12c6 791e E...s.........y.
0x0010: e31b 0e7b 0800 8241 0331 728d ...{...A.1r.
nemesis udp -d en0
# ip length in udp packet is correct
18:53:17.276246 IP 24.220.67.47.45058 > 204.54.51.44.33435: UDP, length 0
0x0000: 4500 001c 3f13 0000 ff11 2150 18dc 432f E...?.....!P..C/
0x0010: cc36 332c b002 829b 0008 71d2 .63,......q.