Skip to content

Fix malloc return value checking; Fix potential memory leak #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2021
Merged

Fix malloc return value checking; Fix potential memory leak #123

merged 1 commit into from
May 1, 2021

Conversation

ivalery111
Copy link
Contributor

It's seems like a mistake in checking malloc return value. It's may lead to memory leak.
Thank you for review:)

@troglobit
Copy link
Collaborator

Definitely a mistake. Thanks!

We shouldn't use new either, reserved keyword in C++, so if you want you could submit a PR for replacing that too across the tree :)

@troglobit troglobit merged commit c5d560a into libnet:master May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivalery111 @troglobit