Allow linking against system libmpack #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d87e91a to
81ae7ab
Compare
a1fdfdd to
9ddc304
Compare
Also fix compilation with USE_SYSTEM_LUA=1 introduced by #4
9ddc304 to
f3c8bf6
Compare
|
I'll check it out tonight. |
|
That works on arch linux. I've reworked the package for lua-mpack locally and wrote a new one for libmpack. I'll see about getting those changes into the official repos once this is merged. I also have some changes for the neovim package to bundle fewer dependencies and use ninja that I can try to get upstreamed while I'm at it. |
|
Also sorry about the regression, was investigating some weird behavior that turned out to be an issue with arch's lua packaging. The fix just rolled out so behavior should be consistent with other distros now. |
|
Works great. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix compilation with USE_SYSTEM_LUA=1 introduced by #4
Close #1