Skip to content

Conversation

msva
Copy link
Contributor

@msva msva commented Nov 2, 2017

  • #includes reordered (clang-tidy)
  • luaL_reg replaced with 5.0-compat #define taken from 5.1's source.
    TODO: just drop it and replace "_r" to "_R" everywhere it is used.
  • a bit rewritten logic for lua_objlen and luaL_register compat-stubs.
    TODO: port to 5.3/5.4 API, and backport stubs to 5.1 (will require
    some amount of dependant code to be rewritten too).

Build/run checks was performed on:
Compilers:

  • gcc-5.4.0
  • gcc-7.2.0
  • clang-5.0.0

Luas:

  • lua-5.1.5
  • lua-5.2.4
  • lua-5.3.4
  • luajit-2.1.0-beta3 (git HEAD@20171101)

 - `#include`s reordered (clang-tidy)
 - luaL_reg replaced with 5.0-compat `#define` taken from 5.1's source.
   TODO: just drop it and replace "_r" to "_R" everywhere it is used.
 - a bit rewritten logic for lua_objlen and luaL_register compat-stubs.
   TODO: port to 5.3/5.4 API, and backport stubs to 5.1 (will require
   some amount of dependant code to be rewritten too).
@tarruda tarruda merged commit 8377ff6 into libmpack:master Nov 4, 2017
@tarruda
Copy link
Contributor

tarruda commented Nov 4, 2017

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants