-
-
Notifications
You must be signed in to change notification settings - Fork 40
Add additional interfaces and interface options #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I fought with this one for a while when I originally made the change to text-wrap
.
It does fix the text wrapping, but now it's not possible to have the full width background colours. I spent too long on it when I last looked, but it's not something I really care for ;) It makes more sense for the text to wrap like you have it.
With text-wrap
:
With break-words whitespace-pre-wrap
:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Theoretically, whitespace-pre-wrap
should preserve whitespace and only create new lines "at newline characters, at <br>
, and as necessary to fill line boxes."
Shouldn't the full-width background colors be preserved?
If not maybe look into using these block characters ███ somehow...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the centering is a pretty important one to get fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an issue with the JavaScript Micron parser that I need to fix. I also noticed that the links up at the top seem to be a bit broken. It just has to do with how it is expecting the positions of the tag which may not always be how they are written. That node looks great for testing though. I'll try and get this done by tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff @RFnexus! Your work on this has really moved things forward!
I'd like to suggest not having the shared interface configurable, that should be handled by Reticulum itself. Or am I misunderstanding, and what you are calling "shared interface" here, is actually |
@markqvist I'll end up renaming this section. It's meant for settings that are shared across all interfaces (more namely common settings), not actually the In the process of refactoring and clean up, so will make sure it's not confused with the internal Btw, thank you very much for your work on this @RFnexus !!! |
Ah, thank @liamcottle, that makes sense! I was the first test subject, apparently, and failed the test ;) |
Yeah I was trying to find the right verbiage for that. "Shared" definitely can get confused with the actual RNS instance settings, but "Common" sounds like they are "common" options used for the interface, (like commonly used) - I tried to address that by putting the "these are optional" label under it. "Common" is definitely better suited though. It's also how they are referenced in the manual. |
… saving an existing interface
Can I be cheeky and ask you to add support for the SOCKSClientInterface I wrote? [1] It takes the same settings as TCPClientInterface, but also 'proxy_host' and 'proxy_port'. Thanks! |
@skyguy it will need to be merged into Reticulum as well first, so before that has happened, it won't work here. |
MeshChat doesn't need the module to edit the config file, and it works if the user adds the module to their .reticulum/interfaces/ folder. |
Ah yes, you're right of course @skyguy. But it will probably need additional logic to check if the module is actually loaded, so users are not presented with an interface type as configurable, but the it actually can't start because the module is not loaded. |
@skyguy CustomInterfaces can definitely be added. My idea for that was just a input field for the interface name and a dropdown for adding key value pairs for whatever that interface expects. Nice work on that feature btw. I tested it and it worked great |
Thanks! I had help from the Chaosnet node's struggles - flushed out some bugs in my error handling! |
What problems did you see on the node @skyguy? Sorry for hijacking this thread for random chatter, though, maybe should move it to another discussion. Just curious, though. |
This PR adds additional interfaces and interface options to MeshChat:
This PR also contains a small fix for text not wrapping in the Micron .
nodeContent
container incomponents/nomadnetwork/NomadNetworkPage.vue