Allow passing read name to mappy #1260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the (optional) ability to pass the read name to the mappy `map` method. Without the read name, the call to `map` can sometimes give different output than the command line version of `minimap2` because of the way minimap uses the hash of the read name to break ties in ordering hits. This can affect which / if certain supplementary alignments are generated, and even which / if non-primary alignments are generated.
|
Thanks a lot for this. Could you merge |
Get rid of additional function, and always accept the name parameter in the mm_map_aux function (can be nullptr if not available).
|
Ok, I've changed the implementation now so that |
|
Thank you! |
|
My pleasure! Thanks as always for the great tools ;). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the (optional) ability to pass the read
name to the mappy
mapmethod. Without theread name, the call to
mapcan sometimes givedifferent output than the command line version
of
minimap2because of the way minimap usesthe hash of the read name to break ties in ordering hits.
This can affect which / if certain supplementary alignments
are generated, and even which / if non-primary alignments
are generated.