Skip to content

feat: portable plugin install in data dir #3773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 11, 2025
Merged

feat: portable plugin install in data dir #3773

merged 7 commits into from
Jul 11, 2025

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Jul 10, 2025

No description provided.

@Yisaer
fix
81247b9 
Signed-off-by: Song Gao <disxiaofei@163.com>
@Yisaer Yisaer requested a review from ngjaying July 10, 2025 06:46
ngjaying
ngjaying reviewed Jul 10, 2025
View reviewed changes
Copy link
Collaborator

@ngjaying ngjaying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the same for native plugin

@Yisaer
fix test
8e560c7 
Signed-off-by: Song Gao <disxiaofei@163.com>
@codecov Codecov
Copy link

codecov bot commented Jul 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.27907% with 29 lines in your changes missing coverage. Please review.

Project coverage is 71.02%. Comparing base (163809e) to head (7746b7e).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
internal/plugin/portable/manager.go 56.76% 11 Missing and 5 partials ⚠️
internal/plugin/native/manager.go 73.47% 7 Missing and 6 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3773      +/-   ##
==========================================
- Coverage   71.06%   71.02%   -0.04%     
==========================================
  Files         433      433              
  Lines       50210    50283      +73     
==========================================
+ Hits        35677    35711      +34     
- Misses      11736    11763      +27     
- Partials     2797     2809      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Yisaer
native double remove
713d123 
Signed-off-by: Song Gao <disxiaofei@163.com>
Yisaer added 4 commits July 11, 2025 11:01
@Yisaer
fix read
ea862b6 
Signed-off-by: Song Gao <disxiaofei@163.com>
@Yisaer
fix
5917db2 
Signed-off-by: Song Gao <disxiaofei@163.com>
@Yisaer
fix
3cfd8f1 
Signed-off-by: Song Gao <disxiaofei@163.com>
@Yisaer
fix
7746b7e 
Signed-off-by: Song Gao <disxiaofei@163.com>
@ngjaying ngjaying merged commit 2b0e9d5 into lf-edge:master Jul 11, 2025
59 of 60 checks passed
ngjaying pushed a commit that referenced this pull request Jul 14, 2025
@Yisaer @ngjaying
feat(plugin): install in data dir (#3773)
8d7f588 
Signed-off-by: Song Gao <disxiaofei@163.com>
ngjaying pushed a commit that referenced this pull request Jul 14, 2025
@Yisaer @ngjaying
feat(plugin): install in data dir (#3773)
37cc605 
Signed-off-by: Song Gao <disxiaofei@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngjaying ngjaying ngjaying approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yisaer @ngjaying