Skip to content

feat(slice): add slice mode #3756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2025
Merged

feat(slice): add slice mode #3756

merged 1 commit into from
Jun 27, 2025

Conversation

ngjaying
Copy link
Collaborator

No description provided.

@ngjaying
feat(slice): add slice mode (#3745) (#100)
20695bf 
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
@ngjaying ngjaying marked this pull request as ready for review June 27, 2025 07:52
@ngjaying ngjaying requested a review from Yisaer June 27, 2025 07:52
@ngjaying ngjaying merged commit 5f06668 into master Jun 27, 2025
69 of 70 checks passed
@ngjaying ngjaying deleted the slice branch June 27, 2025 07:57
@codecov Codecov
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

Attention: Patch coverage is 75.12101% with 257 lines in your changes missing coverage. Please review.

Project coverage is 70.95%. Comparing base (232aa83) to head (20695bf).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
internal/topo/planner/planner.go 71.33% 34 Missing and 9 partials ⚠️
internal/converter/json/converter.go 57.61% 29 Missing and 10 partials ⚠️
internal/xsql/slice_tuple.go 62.64% 32 Missing and 2 partials ⚠️
internal/xsql/valuer.go 72.55% 26 Missing and 2 partials ⚠️
internal/topo/planner/dataSourcePlan.go 63.04% 13 Missing and 4 partials ⚠️
internal/topo/node/decode_op.go 54.29% 14 Missing and 2 partials ⚠️
internal/topo/schema/source.go 89.13% 14 Missing and 1 partial ⚠️
internal/converter/delimited/converter.go 66.67% 9 Missing and 2 partials ⚠️
internal/topo/node/transform_op.go 73.68% 6 Missing and 4 partials ⚠️
internal/topo/node/encode_op.go 60.87% 4 Missing and 5 partials ⚠️
... and 8 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3756      +/-   ##
==========================================
- Coverage   71.07%   70.95%   -0.12%     
==========================================
  Files         429      430       +1     
  Lines       49237    49832     +595     
==========================================
+ Hits        34992    35354     +362     
- Misses      11488    11696     +208     
- Partials     2757     2782      +25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yisaer Yisaer Yisaer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ngjaying @Yisaer