Skip to content

feat(slice): add slice mode #3745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2025
Merged

feat(slice): add slice mode #3745

merged 1 commit into from
Jun 26, 2025

Conversation

ngjaying
Copy link
Collaborator

No description provided.

@ngjaying ngjaying force-pushed the slice branch 2 times, most recently from 509e3f1 to ca9bebd Compare June 18, 2025 03:54
@codecov Codecov
Copy link

codecov bot commented Jun 18, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.02439% with 256 lines in your changes missing coverage. Please review.

Project coverage is 70.96%. Comparing base (64f925c) to head (1645915).
Report is 1 commits behind head on master-x.

Files with missing lines Patch % Lines
internal/topo/planner/planner.go 71.33% 34 Missing and 9 partials ⚠️
internal/converter/json/converter.go 57.61% 29 Missing and 10 partials ⚠️
internal/xsql/slice_tuple.go 62.64% 32 Missing and 2 partials ⚠️
internal/xsql/valuer.go 72.55% 26 Missing and 2 partials ⚠️
internal/topo/planner/dataSourcePlan.go 63.04% 13 Missing and 4 partials ⚠️
internal/topo/node/decode_op.go 54.29% 14 Missing and 2 partials ⚠️
internal/topo/schema/source.go 89.05% 14 Missing and 1 partial ⚠️
internal/converter/delimited/converter.go 66.67% 9 Missing and 2 partials ⚠️
internal/topo/node/transform_op.go 73.68% 6 Missing and 4 partials ⚠️
internal/topo/node/encode_op.go 60.87% 4 Missing and 5 partials ⚠️
... and 8 more
Additional details and impacted files 
@@             Coverage Diff              @@
##           master-x    #3745      +/-   ##
============================================
- Coverage     71.05%   70.96%   -0.10%     
============================================
  Files           428      429       +1     
  Lines         49006    49602     +596     
============================================
+ Hits          34820    35196     +376     
- Misses        11446    11640     +194     
- Partials       2740     2766      +26

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ngjaying ngjaying force-pushed the slice branch 8 times, most recently from dbf5c26 to b0d83f2 Compare June 20, 2025 09:15
@ngjaying
feat(slice): add slice mode
1645915 
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
@ngjaying ngjaying marked this pull request as ready for review June 23, 2025 03:56
@ngjaying ngjaying requested a review from Yisaer June 23, 2025 03:56
@ngjaying ngjaying merged commit 3edb34f into lf-edge:master-x Jun 26, 2025
60 checks passed
ngjaying added a commit that referenced this pull request Jun 27, 2025
@ngjaying
feat(slice): add slice mode (#3745) (#100)
20695bf 
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
ngjaying added a commit that referenced this pull request Jun 27, 2025
@ngjaying
feat(slice): add slice mode (#3745) (#100)
5f06668 
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yisaer Yisaer Awaiting requested review from Yisaer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ngjaying