fix(kafka): fix kafka source properties bug #3724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lin <jie.lin@thetasensors.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master-2.1 #3724 +/- ##
==============================================
- Coverage 71.36% 71.30% -0.06%
==============================================
Files 417 417
Lines 48354 48354
==============================================
- Hits 34506 34478 -28
- Misses 11156 11180 +24
- Partials 2692 2696 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Yisaer
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My apologies, I mistakenly confused the JSON structure between Kafka source and Kafka sink in [PR].(#3686)
Just patched this - my bad for mixing up the source/sink JSON formats earlier.