Skip to content

chore: merge bugfixes #3720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 27, 2025
Merged

chore: merge bugfixes #3720

merged 6 commits into from
May 27, 2025

Conversation

ngjaying
Copy link
Collaborator

No description provided.

Yisaer and others added 6 commits May 27, 2025 10:00
@Yisaer @ngjaying
fix: improve incremnetal tumbling window perf (lf-edge#3693)
bcbe15b 
Signed-off-by: Song Gao <disxiaofei@163.com>
(cherry picked from commit c2163d4)
@Yisaer @ngjaying
fix: fix inc window metrics (lf-edge#3681)
4d4cc69 
Signed-off-by: Song Gao <disxiaofei@163.com>
(cherry picked from commit 3133876)
@ngjaying
fix(rule): eof set topo to nil for noneof rule (lf-edge#3717)
edb231a 
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
(cherry picked from commit 9f7747b)
@ngjaying
fix(topo): broadcast multi output clone problem (lf-edge#3715)
51080ad 
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
(cherry picked from commit 43ca794)
@ngjaying
fix(topo): subtopo should always detach rule (lf-edge#3716)
09c0239 
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
(cherry picked from commit 11ff6ad)
@ngjaying
fix(topo): register lag state type (lf-edge#3719)
975bf34 
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
(cherry picked from commit 3ef13de)
@codecov Codecov
Copy link

codecov bot commented May 27, 2025

Codecov Report

Attention: Patch coverage is 78.72340% with 30 lines in your changes missing coverage. Please review.

Please upload report for BASE (master-2.1@3139397). Learn more about missing BASE report.

Files with missing lines Patch % Lines
internal/topo/node/window_inc_agg_op.go 44.19% 24 Missing ⚠️
internal/binder/function/funcs_misc.go 85.00% 1 Missing and 2 partials ⚠️
internal/topo/rule/state.go 50.00% 2 Missing ⚠️
internal/topo/subtopo.go 96.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##             master-2.1    #3720   +/-   ##
=============================================
  Coverage              ?   71.34%           
=============================================
  Files                 ?      417           
  Lines                 ?    48354           
  Branches              ?        0           
=============================================
  Hits                  ?    34495           
  Misses                ?    11164           
  Partials              ?     2695

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ngjaying ngjaying marked this pull request as ready for review May 27, 2025 02:17
@ngjaying ngjaying requested a review from Yisaer May 27, 2025 02:17
@ngjaying ngjaying merged commit ac910c5 into lf-edge:master-2.1 May 27, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yisaer Yisaer Yisaer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ngjaying @Yisaer