Skip to content

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented May 13, 2025

The old way cost too much performance

Signed-off-by: Song Gao <disxiaofei@163.com>
@Yisaer Yisaer requested a review from ngjaying May 13, 2025 03:33
Copy link

codecov bot commented May 13, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 24 lines in your changes missing coverage. Please review.

Project coverage is 71.12%. Comparing base (75952ef) to head (60201f8).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
internal/topo/node/window_inc_agg_op.go 33.33% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3693      +/-   ##
==========================================
- Coverage   71.16%   71.12%   -0.03%     
==========================================
  Files         428      428              
  Lines       48791    48809      +18     
==========================================
- Hits        34719    34715       -4     
- Misses      11354    11375      +21     
- Partials     2718     2719       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ngjaying ngjaying merged commit c2163d4 into lf-edge:master May 15, 2025
59 of 60 checks passed
ngjaying pushed a commit to ngjaying/kuiper that referenced this pull request May 27, 2025
Signed-off-by: Song Gao <disxiaofei@163.com>
(cherry picked from commit c2163d4)
ngjaying pushed a commit that referenced this pull request May 27, 2025
Signed-off-by: Song Gao <disxiaofei@163.com>
(cherry picked from commit c2163d4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants