refactor(server): do not catch fatal sigs #3692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed an unnecessary nil check for the channel reference in the Close method. Simplifies the code logic while maintaining its intended functionality. Signed-off-by: Jiyong Huang <huangjy@emqx.io>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3692 +/- ##
==========================================
+ Coverage 71.12% 71.15% +0.03%
==========================================
Files 428 428
Lines 48791 48791
==========================================
+ Hits 34700 34713 +13
+ Misses 11370 11358 -12
+ Partials 2721 2720 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Yisaer
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed an unnecessary nil check for the channel reference in the Close method. Simplifies the code logic while maintaining its intended functionality.