Skip to content

feat(conf): default cert and encryption conf #3677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 21, 2025
Merged

feat(conf): default cert and encryption conf #3677

merged 6 commits into from
Apr 21, 2025

Conversation

ngjaying
Copy link
Collaborator

No description provided.

ngjaying added 5 commits April 21, 2025 09:55
@ngjaying
feat(enc): refactor enc pkg and add decryptor
bd9238a 
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
(cherry picked from commit e979c6b62b133649a148f2e33ca10a7c9ff00f61)
@ngjaying
feat(conf): default cert and encryption conf
8ce8136 
Signed-off-by: Jiyong Huang <huangjy@emqx.io>

(cherry picked from commit 9aa69a58b30cc9bd9e563b6224359b639c74864f)
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
@ngjaying
refactor(conf): move conf model to pkg
5a05343 
Signed-off-by: Jiyong Huang <huangjy@emqx.io>

(cherry picked from commit aa240acd3ff4a0d1971bf1186302fd701082fb50)
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
@ngjaying
refactor(enc): provide new func with basic conf
badceba 
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
(cherry picked from commit bf585e5d6a00e86bde6c3ee1b1caca2c376b61d6)
@ngjaying
feat(mod): export conf hook
380bc8c 
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
(cherry picked from commit 42030b64857d5078b79425b7c8f9f00dd0a204c5)
@codecov Codecov
Copy link

codecov bot commented Apr 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.86207% with 98 lines in your changes missing coverage. Please review.

Project coverage is 71.10%. Comparing base (06af706) to head (c9aafa7).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
internal/conf/conf.go 53.73% 25 Missing and 6 partials ⚠️
pkg/cert/cert.go 72.37% 20 Missing and 1 partial ⚠️
pkg/model/conf_security.go 52.17% 8 Missing and 3 partials ⚠️
internal/server/server.go 9.09% 8 Missing and 2 partials ⚠️
modules/encryptor/aes/gcm.go 78.05% 6 Missing and 3 partials ⚠️
modules/encryptor/encryptor.go 83.72% 5 Missing and 2 partials ⚠️
modules/encryptor/aes/aes.go 80.00% 2 Missing and 1 partial ⚠️
pkg/cert/default.go 72.73% 2 Missing and 1 partial ⚠️
pkg/modules/conf.go 0.00% 2 Missing ⚠️
tools/plugin_server/plugin_test_server.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3677      +/-   ##
==========================================
- Coverage   71.14%   71.10%   -0.04%     
==========================================
  Files         423      428       +5     
  Lines       48699    48787      +88     
==========================================
+ Hits        34643    34687      +44     
- Misses      11340    11379      +39     
- Partials     2716     2721       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ngjaying
test: add test for default cert/enc
c9aafa7 
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
@ngjaying ngjaying marked this pull request as ready for review April 21, 2025 04:06
@ngjaying ngjaying requested a review from Yisaer April 21, 2025 07:13
@ngjaying ngjaying merged commit 9edf3d5 into lf-edge:master Apr 21, 2025
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yisaer Yisaer Yisaer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ngjaying @Yisaer