Skip to content

fix: sql stmt only prepared once #3672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

fix: sql stmt only prepared once #3672

merged 1 commit into from
Apr 16, 2025

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Apr 16, 2025 •
edited by ngjaying
Loading

Closes #3667

@Yisaer
only prepared once
128cbbb 
Signed-off-by: Song Gao <disxiaofei@163.com>
@Yisaer Yisaer requested a review from ngjaying April 16, 2025 03:16
@Yisaer Yisaer mentioned this pull request Apr 16, 2025
Closed
@codecov Codecov
Copy link

codecov bot commented Apr 16, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 48.27586% with 15 lines in your changes missing coverage. Please review.

Project coverage is 71.13%. Comparing base (16db819) to head (128cbbb).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
internal/pkg/store/sql/sqlKv.go 48.28% 10 Missing and 5 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3672      +/-   ##
==========================================
- Coverage   71.18%   71.13%   -0.04%     
==========================================
  Files         423      423              
  Lines       48671    48699      +28     
==========================================
- Hits        34643    34642       -1     
- Misses      11320    11343      +23     
- Partials     2708     2714       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ngjaying ngjaying merged commit 0022e59 into lf-edge:master Apr 16, 2025
59 of 60 checks passed
ngjaying pushed a commit to ngjaying/kuiper that referenced this pull request Apr 21, 2025
@Yisaer @ngjaying
fix(kv): sql stmt only prepared once (lf-edge#3672)
323e64c 
Signed-off-by: Song Gao <disxiaofei@163.com>
(cherry picked from commit 0022e59)
ngjaying pushed a commit to ngjaying/kuiper that referenced this pull request Apr 21, 2025
@Yisaer @ngjaying
fix(kv): sql stmt only prepared once (lf-edge#3672)
f89502f 
Signed-off-by: Song Gao <disxiaofei@163.com>
(cherry picked from commit 0022e59)
ngjaying pushed a commit that referenced this pull request Apr 21, 2025
@Yisaer @ngjaying
fix(kv): sql stmt only prepared once (#3672)
3d25899 
Signed-off-by: Song Gao <disxiaofei@163.com>
(cherry picked from commit 0022e59)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngjaying ngjaying ngjaying approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory keeps on increasing while updating existing rule through REST API
2 participants
@Yisaer @ngjaying