Skip to content

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Mar 25, 2025

No description provided.

Signed-off-by: Song Gao <disxiaofei@163.com>
@Yisaer Yisaer requested a review from ngjaying March 25, 2025 08:11
Signed-off-by: Song Gao <disxiaofei@163.com>
Copy link
Collaborator

@ngjaying ngjaying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Periodic pull connection status may have overhead. Why not just update the connection status metrics in the connection status change handler?

@ngjaying ngjaying self-requested a review March 28, 2025 03:39
@Yisaer Yisaer merged commit d415a8a into lf-edge:master Mar 28, 2025
56 checks passed
Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (428c427) to head (fbae44b).
Report is 11 commits behind head on master.

Additional details and impacted files
@@      Coverage Diff       @@
##   master   #3637   +/-   ##
==============================
==============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants