Skip to content

fix(conf): load connection env wrong type #3631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2025
Merged

fix(conf): load connection env wrong type #3631

merged 1 commit into from
Mar 21, 2025

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Mar 21, 2025 •
edited by ngjaying
Loading

Closes #3621

@Yisaer
fix
fbc03fe 
Signed-off-by: Song Gao <disxiaofei@163.com>
@Yisaer Yisaer requested a review from ngjaying March 21, 2025 08:41
@codecov Codecov
Copy link

codecov bot commented Mar 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 52.63158% with 9 lines in your changes missing coverage. Please review.

Project coverage is 71.06%. Comparing base (489a253) to head (fbc03fe).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
internal/conf/env_manager.go 52.63% 6 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3631      +/-   ##
==========================================
- Coverage   71.07%   71.06%   -0.02%     
==========================================
  Files         418      418              
  Lines       48289    48389     +100     
==========================================
+ Hits        34321    34383      +62     
- Misses      11291    11316      +25     
- Partials     2677     2690      +13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ngjaying ngjaying changed the title fix: fix load connection env value fix(conf): load connection env wrong type Mar 21, 2025
@ngjaying ngjaying merged commit dcc734c into lf-edge:master Mar 21, 2025
62 of 63 checks passed
ngjaying pushed a commit to ngjaying/kuiper that referenced this pull request Mar 31, 2025
@Yisaer @ngjaying
fix(conf): load connection env wrong type (lf-edge#3631)
d17d36f 
Signed-off-by: Song Gao <disxiaofei@163.com>
ngjaying pushed a commit that referenced this pull request Mar 31, 2025
@Yisaer @ngjaying
fix(conf): load connection env wrong type (#3631)
9f51be6 
Signed-off-by: Song Gao <disxiaofei@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngjaying ngjaying ngjaying approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create rule got "connection edgex.mqttMsgBus not existed" error
2 participants
@Yisaer @ngjaying