Skip to content

feat(op): support streaming batch #3629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 24, 2025
Merged

feat(op): support streaming batch #3629

merged 12 commits into from
Mar 24, 2025

Conversation

ngjaying
Copy link
Collaborator

No description provided.

ngjaying added 11 commits March 20, 2025 14:51
@ngjaying
feat(sink): move batch after encode (lf-edge#3461)
60394f4 
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
@ngjaying
chore(op): csv header encode before batch
8fb10ee 
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
@ngjaying
chore(fix): batch csv missing nl
3270d3b 
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
@ngjaying
feat(op): streaming batch (lf-edge#3487)
36895b5 
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
@ngjaying
feat(converter): add csv writer (lf-edge#3489)
08bf9dc 
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
@ngjaying
chore(schema): simple sink schema support
5c17dc5 
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
@ngjaying
feat(converter): register csv writer (lf-edge#3490)
529f70f 
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
@ngjaying
chore(test): remove batch trace fvt
5ac6536 
Restore later

Signed-off-by: Jiyong Huang <huangjy@emqx.io>
@ngjaying
test: adapt change
e536a01 
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
@ngjaying
fix: adapt change
1547b81 
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
@ngjaying
fix: adapt change
4bc2f3f 
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
@codecov Codecov
Copy link

codecov bot commented Mar 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 76.34855% with 57 lines in your changes missing coverage. Please review.

Project coverage is 71.00%. Comparing base (328b9b6) to head (ea4ccc2).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
internal/topo/node/batch_writer_op.go 59.78% 29 Missing and 8 partials ⚠️
internal/server/rule_manager.go 50.00% 4 Missing and 3 partials ⚠️
internal/converter/delimited/writer.go 81.82% 4 Missing and 2 partials ⚠️
internal/converter/stack_writer.go 85.00% 2 Missing and 1 partial ⚠️
internal/topo/planner/planner_sink.go 84.21% 2 Missing and 1 partial ⚠️
internal/topo/node/sink_node.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3629      +/-   ##
==========================================
- Coverage   71.05%   71.00%   -0.06%     
==========================================
  Files         418      421       +3     
  Lines       48291    48451     +160     
==========================================
+ Hits        34312    34399      +87     
- Misses      11301    11354      +53     
- Partials     2678     2698      +20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ngjaying
feat: support transform list
ea4ccc2 
Also add ut

Signed-off-by: Jiyong Huang <huangjy@emqx.io>
@ngjaying ngjaying marked this pull request as ready for review March 21, 2025 07:51
@ngjaying ngjaying merged commit 11adc63 into lf-edge:master Mar 24, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yisaer Yisaer Yisaer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ngjaying @Yisaer