Skip to content

feat(planner): rule option check #3617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 14, 2025
Merged

feat(planner): rule option check #3617

merged 2 commits into from
Mar 14, 2025

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Mar 13, 2025 •
edited by ngjaying
Loading

Rule option disableBufferFullDiscard is not allowed when source is shared

@Yisaer
fix
cbcf6ec 
Signed-off-by: Song Gao <disxiaofei@163.com>
@Yisaer Yisaer requested a review from ngjaying March 13, 2025 05:55
@codecov Codecov
Copy link

codecov bot commented Mar 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 71.07%. Comparing base (77d23f9) to head (831b756).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
internal/topo/planner/planner.go 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3617      +/-   ##
==========================================
- Coverage   71.10%   71.07%   -0.03%     
==========================================
  Files         418      418              
  Lines       48265    48289      +24     
==========================================
+ Hits        34318    34320       +2     
- Misses      11262    11294      +32     
+ Partials     2685     2675      -10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ngjaying ngjaying changed the title fix: fix shared source disableBufferFullDiscard feat: disallow shared source for disableBufferFullDiscard Mar 14, 2025
ngjaying
ngjaying reviewed Mar 14, 2025
View reviewed changes
@ngjaying ngjaying changed the title feat: disallow shared source for disableBufferFullDiscard feat: disallow shared source disableBufferFullDiscard Mar 14, 2025
@ngjaying ngjaying changed the title feat: disallow shared source disableBufferFullDiscard feat(planner): disallow blocking mode for shared source Mar 14, 2025
@ngjaying ngjaying changed the title feat(planner): disallow blocking mode for shared source feat(planner): rule option check for shared source Mar 14, 2025
@ngjaying ngjaying changed the title feat(planner): rule option check for shared source feat(planner): rule option check Mar 14, 2025
@Yisaer
fix
831b756 
Signed-off-by: Song Gao <disxiaofei@163.com>
@Yisaer Yisaer requested a review from ngjaying March 14, 2025 03:45
@ngjaying ngjaying merged commit 489a253 into lf-edge:master Mar 14, 2025
58 checks passed
ngjaying pushed a commit to ngjaying/kuiper that referenced this pull request Mar 31, 2025
@Yisaer @ngjaying
feat(planner): rule option check (lf-edge#3617)
7403268 
Signed-off-by: Song Gao <disxiaofei@163.com>
ngjaying pushed a commit that referenced this pull request Mar 31, 2025
@Yisaer @ngjaying
feat(planner): rule option check (#3617)
f08ae9e 
Signed-off-by: Song Gao <disxiaofei@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngjaying ngjaying ngjaying approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yisaer @ngjaying