fix(planner): sql sink should handle fields #3612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some sink need to handle common properties by itself instead of delegate to the transform op or other sink splitted op Signed-off-by: Jiyong Huang <huangjy@emqx.io>
Yisaer
approved these changes
Mar 12, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3612 +/- ##
==========================================
+ Coverage 71.11% 71.13% +0.03%
==========================================
Files 418 418
Lines 48269 48274 +5
==========================================
+ Hits 34322 34339 +17
+ Misses 11264 11251 -13
- Partials 2683 2684 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some sink need to handle common properties by itself instead of delegate to the transform op or other sink splitted op